-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convenience methods to interact with container #69
Add convenience methods to interact with container #69
Conversation
sbglasius
commented
Nov 1, 2024
- Exec in Container
- Place files in container
- Mount directories in container
- Download files from container
* Exec in Container * Place files in container * Mount directories in container * Download files from container
Checked in a local version of grails-functional-tests (
where without the convenience methods a cast is needed:
is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
There are some unused imports and some whitespace on line 101.
@jdaugherty Can you confirm that it works on MacOS with |
@sbglasius Would it be benefitial to expose the container via: BrowserWebDriverContainer getContainer() {
return webDriverContainer
} And then you can access all methods on the container in the tests, eg: |
…erContainer via getContainer() instead.
Followed @matrei's suggestion, removed convenience methods and added |
Nice! Now there are some unused imports and a whitespace issue (Line 122) again. If @jdaugherty, can confirm the MacOS fix, that should probably be in it's own PR or commit as it fixes a bug. Otherwise, I'd say Squash and merge on the new feature! |
I'm working on confirming the change on MacOS, but I noticed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm the expose ports change fixes the MacOS issue.
the reference to |