Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reporting support to ContainerGebSpec #78

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conversation

matrei
Copy link
Contributor

@matrei matrei commented Nov 17, 2024

Introduces a boolean reportingEnabled = false property in ContainerGebSpec that subclasses can override to enable reporting functionality.

To enable reporting, you must also specify the reportsDir property. This can typically be configured in resources/GebConfig.groovy or via the geb.reportsDir system property.

Introduces a `boolean reportingEnabled = false` property in `ContainerGebSpec` that subclasses can override to enable reporting functionality.

To enable reporting, you must also specify the `reportsDir` property. This can typically be configured in `resources/GebConfig.groovy` or via the `geb.reportsDir` system property.
@matrei matrei requested a review from sbglasius November 17, 2024 21:38
Copy link
Contributor

@sbglasius sbglasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider my replacement for GebTestManagerProvider or leave it as is. I think it looks good! ⭐

Refactored `GebTestManagerProvider` to leverage
Groovy's `@Lazy` annotation for the `GebTestManager` fields.

This change simplifies the code and results in the use of
the initialization-on-demand holder pattern instead of
using synchronization with double-checked locking pattern
for the field initialization.
@matrei matrei requested a review from sbglasius November 18, 2024 08:35
Copy link
Contributor

@sbglasius sbglasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@matrei matrei merged commit c459b49 into 5.0.x Nov 18, 2024
5 checks passed
@matrei matrei deleted the matrei/feat-reporting branch November 18, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants