Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change @Ignore tests to @PendingFeature #170

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Change @Ignore tests to @PendingFeature #170

merged 3 commits into from
Dec 16, 2024

Conversation

matrei
Copy link
Collaborator

@matrei matrei commented Dec 15, 2024

And remove @Ignore from a passing test

@matrei
Copy link
Collaborator Author

matrei commented Dec 16, 2024

Related to #164

@matrei matrei merged commit 6a31423 into 6.0.x Dec 16, 2024
13 checks passed
@matrei matrei deleted the matrei/ignored-tests branch December 16, 2024 15:20
jdaugherty
jdaugherty reviewed Dec 16, 2024
View reviewed changes
examples/pubsub-demo/build.gradle
}
}

// Must be applied after version is set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matrei I think this is only for the publish plugin. For the gsp / web plugins this isn't a requirement.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, I mixed it up
#171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdaugherty jdaugherty jdaugherty left review comments

@jamesfredley jamesfredley jamesfredley approved these changes

@codeconsole codeconsole Awaiting requested review from codeconsole

Assignees
No one assigned
Labels
feature maintenance test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matrei @jdaugherty @jamesfredley @grails-build