Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update groovy-joint-workflow #178

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Conversation

matrei
Copy link
Collaborator

@matrei matrei commented Jan 1, 2025

And also go over and update the rest of the workflows.

grails/grails-core#13699

@matrei matrei marked this pull request as draft January 1, 2025 15:27
matrei added 2 commits January 1, 2025 16:48
Make the groovy version configurable by property or env variable.
Setting `groovy.version` property does not seem to suffice to override the groovy version in the bom.
@matrei matrei marked this pull request as ready for review January 1, 2025 20:34
@matrei matrei requested a review from jdaugherty January 1, 2025 20:34
Copy link
Contributor

@jdaugherty jdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. My only real concern is publishing a snapshot or documentation while an artifact is being resolved to the temporary maven repository.

.github/workflows/gradle.yml Outdated Show resolved Hide resolved
.github/workflows/gradle.yml Outdated Show resolved Hide resolved
.github/workflows/gradle.yml Outdated Show resolved Hide resolved
.github/workflows/groovy-joint-workflow.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@matrei matrei requested a review from jdaugherty January 1, 2025 23:23
@matrei matrei merged commit 0626cdf into 6.0.x Jan 2, 2025
8 checks passed
@matrei matrei deleted the matrei/fix-groovy-joint-workflow branch January 2, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants