Cache evict not working with a custom key #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching and eviction does not work with the following example:
According to my checks the problem is the
@EqualsAndHashCode
annotation creates a comparison where the method name is also part of the key. Therefore tha evict call cannot invalidate a cache entry.The old manual implementation causes the same problem.
Therefore I modified the old manual implementation to skip the method name comparison if the provided keys are identical.
This is not a very nice solution but it solved the problem in my use cases.
A improved implementation might be tested using the added integration tests.