Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type 'pom' and scope 'import' for grails-bom and jackson-bom #14052

Merged
merged 5 commits into from
Mar 3, 2025

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Mar 3, 2025

These two BOMs were missing:

<type>pom</type>
<scope>import</scope>

Now they have type and scope and appear before spring-boot-dependencies

<dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>org.apache.groovy</groupId>
        <artifactId>groovy-bom</artifactId>
        <version>${groovy.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
      <dependency>
        <groupId>com.fasterxml.jackson</groupId>
        <artifactId>jackson-bom</artifactId>
        <version>${jackson.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
      <dependency>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-dependencies</artifactId>
        <version>${spring-boot.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
....
</dependencyManagement>

this resolves the following on groovydoc task when spring-boot-dependencies is using a different Groovy Version.

Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. Module [groovy-xml is loaded in version 4.0.25 and you are trying to load version 4.0.24

@jamesfredley jamesfredley merged commit 0be8d8d into 7.0.x Mar 3, 2025
22 checks passed
@jamesfredley jamesfredley deleted the add-type-scope-to-boms branch March 3, 2025 22:50
@jamesfredley jamesfredley added this to the grails:7.0.0-M2 milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants