Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: README.md documentation links fix/update #432

Merged
merged 3 commits into from
Nov 28, 2024
Merged

chore: README.md documentation links fix/update #432

merged 3 commits into from
Nov 28, 2024

Conversation

gsartori
Copy link
Contributor

@gsartori
Copy link
Contributor Author

I am not sure if the Grails Scaffolding plugin should be included in the list since it is a standard feature documented in Grails docs: https://docs.grails.org/snapshot/guide/scaffolding.html and its GitHub README.md does not include a link to documentation: https://github.com/grails/scaffolding

matrei
matrei requested changes Nov 22, 2024
View reviewed changes
grails-forge-core/src/main/java/org/grails/forge/feature/assetPipeline/AssetPipeline.java Outdated Show resolved Hide resolved
grails-forge-core/src/main/java/org/grails/forge/feature/test/GebWithTestcontainers.java Outdated Show resolved Hide resolved
grails-forge-core/src/main/java/org/grails/forge/feature/test/GebWithTestcontainers.java Show resolved Hide resolved
grails-forge-core/src/main/java/org/grails/forge/feature/test/GebWithWebDriverBinaries.java Show resolved Hide resolved
grails-forge-core/src/main/java/org/grails/forge/feature/test/GebWithWebDriverBinaries.java Outdated Show resolved Hide resolved
grails-forge-core/src/main/java/org/grails/forge/feature/view/Scaffolding.java Outdated Show resolved Hide resolved
grails-forge-core/src/main/java/org/grails/forge/feature/view/Scaffolding.java Outdated Show resolved Hide resolved
matrei
matrei reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment and you can also update the year in the license header for the files you have changed where it's needed.

Thanks for taking the time to do this PR!

grails-forge-core/src/main/java/org/grails/forge/feature/assetPipeline/AssetPipeline.java Outdated Show resolved Hide resolved
matrei
matrei approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! Do you have access to merge or should I do it?

@gsartori
Copy link
Contributor Author

I don't know but for now I prefer if you do it :)

@matrei matrei merged commit 2ab9f4a into grails:7.0.x Nov 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrei matrei matrei approved these changes

Assignees
No one assigned
Labels
bug chore maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsartori @matrei @grails-build