skip 4 failing tests, 3 are tests which failed, then worked and now fail again

[jamesfredley]

3 of these were working and were restored on 10/3/24, but are now failing again. https://github.com/grails/grails-functional-tests/pull/251/files

#254 - list of failing tests

This PR is not needed if we fix the cause identified in the comments below.

[matrei]

Looking at the time when the tests started failing, it seems to be this change that broke the tests: grails/grails-core@bff1a68

[jamesfredley]

There were two failures after that commit, but the errors were different and appeared to resolve, possibly a stale cached version of grails-async:6.0.0-SNAPSHOT.

grails/grails-core@2edb2e3 is the PR which triggered https://github.com/grails/grails-functional-tests/actions/runs/11311524760 which was the first time we saw these 4 failures, actually 8, but 4 are still failing.

[matrei]

Looking at the test failures and timing, I still think this change to grails-async (grails/grails-async@e5531e7) might be a suspect. @codeconsole What do you think?

[codeconsole]

@matrei doubt it. It doesn't seem like it should have any impact.

It isn't possible for the response to be a org.grails.web.sitemesh.GrailsContentBufferingResponse so that condition should never happen. As far as I know that class hasn't been used anywhere else.

It is also more plausible it could be something that was in 7 and got lost merging back down to 6.

grails/grails-async@4904543

It was on my bucket list to test async, but haven't had time to get to it.

[matrei]

We are getting java.lang.NoClassDefFoundError: org/apache/commons/lang/ClassUtils in this test.

So, this is definitively a probably culprit: grails/grails-core@2edb2e3

[codeconsole]

@matrei That method was removed from the fields plugin. Is it resolving an old version of the plugin?

https://github.com/gpc/fields/blob/6.0.x/src/main/groovy/grails/plugin/formfields/DelegatingBeanPropertyAccessorImpl.groovy

Are the tests resolving the latest fields 6.0.0-SNAPSHOT?

[matrei]

We are getting java.lang.NoClassDefFoundError: org/apache/commons/lang/ClassUtils in this test.
So, this is definitively a probably culprit: grails/grails-core@2edb2e3

Scratch that, this test is working now.

[matrei]

@codeconsole What does it take to make sitemesh layouts work in the test apps in this repo?

grails-functional-tests/app1/src/integration-test/groovy/functionaltests/sitemesh/SitemeshLayoutFunctionalSpec.groovy

Line 12 in b476ac6

@PendingFeature(reason = 'title is empty')

[codeconsole]

@codeconsole What does it take to make sitemesh layouts work in the test apps in this repo?

grails-functional-tests/app1/src/integration-test/groovy/functionaltests/sitemesh/SitemeshLayoutFunctionalSpec.groovy

Line 12 in b476ac6

@PendingFeature(reason = 'title is empty')

Right now you manually have to add the plugin dependency, but it should be me made an api dependency of another dependency. The question is, which one? I am not sure if gsp should depend on sitemesh. What is responsible for mapping gsps to the layouts folder?

[jamesfredley]

I am merging this so that we have working functional tests to use with https://docs.google.com/document/d/1k5J5ZqUW-ofOMuZJ-eljrg4yqAFHBAhQFa-sY-1EQ5o/edit#heading=h.7j0mm9z5mgub. I have been using this branch to test the last several changes, including for grails-core.

The two distinct groups of test failures will be moved to issues.

[jamesfredley]

#256

[jamesfredley]

#257