Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails 7 - Spring Security - Cleanup #1045

Closed
wants to merge 22 commits into from
Closed

Conversation

jdaugherty
Copy link
Contributor

@jdaugherty jdaugherty commented Dec 16, 2024

Follow-up to #1034

This PR:

  • Converts to ContainerGebSpec
  • Updates to the latest asset plugin
  • Runs the tests always instead of only on a PR
  • Converts to the newer java version syntax in gradle

Note: issues still after this PR:

  • We need to update the s2 quick start apps

@jdaugherty
Copy link
Contributor Author

@codeconsole @matrei @jamesfredley This was my attempt at trying to use the grails bom, start using ContainerGebSpec, and update to the latest versions so we can release the M1 of grails. There are a lot of errors here and I think they've been here for awhile since the tests were not running outside of PRs. Does anyone have any ideas on some of these errors?

@jdaugherty
Copy link
Contributor Author

Looks like we had some usages of ReportingGebSpec so I replaced those - I also added the @Integration to the tests in functional-tests since they were all under the integration directory.

@jdaugherty jdaugherty closed this Dec 17, 2024
@jdaugherty
Copy link
Contributor Author

Closing for @matrei PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants