Grails 7: grails-spring-security-ui

[bkoehm]

No description provided.

[bkoehm]

Tests are not passing. Needs help from others (possibly from @codeconsole).

[matrei]

I have started looking at the UserSpec test errors. It appears to be related to GSP/Sitemesh, as the page title does not seem to render correctly on /user/search.

[bkoehm]

I have started looking at the UserSpec test errors. It appears to be related to GSP/Sitemesh, as the page title does not seem to render correctly on /user/search.

@matrei My apologies, it looks like we both were working on this at the exact same time. I just saw your comment, just as I pushed a new commit that addresses this:
bkoehm@8a3df41

If you feel that this isn't the right solution, it's no problem, I can drop the commit and force-push.

P.S. There are still test failures, but this addresses the missing page title.

[matrei]

My apologies, it looks like we both were working on this at the exact same time. I just saw your comment, just as I pushed a new commit that addresses this: bkoehm@8a3df41

@bkoehm That's great! I just made this note and went to bed anyways.

So, is this a breaking change in Sitemesh 3, or why did it work before Grails 7? I does not seem to be documented in the upgrade gotchas?

[jdaugherty]

@matrei @bkoehm

There was still a browser.url assignment in AbstractSecuritySpec - this url would be the local machine and not the container. I've gone ahead and pushed a fix for that.

[bkoehm]

My apologies, it looks like we both were working on this at the exact same time. I just saw your comment, just as I pushed a new commit that addresses this: bkoehm@8a3df41

@bkoehm That's great! I just made this note and went to bed anyways.

So, is this a breaking change in Sitemesh 3, or why did it work before Grails 7? I does not seem to be documented in the upgrade gotchas?

@matrei I don't know if Sitemesh 3 has a breaking change related to page titles and I also don't know if this plugin is working for Grails 6.