Set correct Environment Vars for Publish Plugin #168
Conversation
| ARTIFACTORY_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }} | ||
| MAVEN_PUBLISH_USERNAME: ${{ secrets.MAVEN_PUBLISH_USERNAME }} | ||
| MAVEN_PUBLISH_PASSWORD: ${{ secrets.MAVEN_PUBLISH_PASSWORD }} | ||
| MAVEN_PUBLISH_URL: ${{ secrets.MAVEN_PUBLISH_SNAPSHOT_URL }} |
There was a problem hiding this comment.
I'd add GRAILS_PUBLISH_RELEASE: "false" as well. This will force the java ci to always be a snapshot build regardless of version.
| NEXUS_PUBLISH_USERNAME: ${{ secrets.NEXUS_PUBLISH_USERNAME }} | ||
| NEXUS_PUBLISH_PASSWORD: ${{ secrets.NEXUS_PUBLISH_PASSWORD }} | ||
| NEXUS_PUBLISH_URL: ${{ secrets.NEXUS_PUBLISH_RELEASE_URL }} | ||
| NEXUS_PUBLISH_STAGING_PROFILE_ID: ${{ secrets.NEXUS_PUBLISH_STAGING_PROFILE_ID }} | ||
| SIGNING_KEY: ${{ secrets.SIGNING_KEY }} | ||
| SIGNING_PASSPHRASE: ${{ secrets.SIGNING_PASSPHRASE }} |
There was a problem hiding this comment.
I'd add GRAILS_PUBLISH_RELEASE: "true" - this will force the release build to always be a release regardless of a version.
| @@ -32,10 +32,11 @@ jobs: | |||
| - name: "📤 Publish release artifacts to Sonatype" | |||
| id: publish | |||
| env: | |||
| SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} | |||
There was a problem hiding this comment.
I noticed the grails-publish is in the child project, unfortunately, this scenario should fail with:
* What went wrong:
A problem occurred evaluating project ':spring-security-ui'.
> Failed to apply plugin class 'io.github.gradlenexus.publishplugin.NexusPublishPlugin'.
> Cannot run Project.afterEvaluate(Action) when the project is already evaluated.
To test, set your version to a release version locally or set GRAILS_PUBLISH_RELEASE=true. I would add a root build.gradle that adds grails publish similar to https://github.com/grails/grails-spring-security-rest/blob/11b2825244ad80df6824ec18da31d8dd26edf96b/build.gradle#L96
There was a problem hiding this comment.
There is a test case for this scenario in https://github.com/grails/grails-gradle-plugin/blob/e62f68b46bc3bd8051121c7e65476c22022308d4/src/e2eTest/groovy/org/grails/gradle/test/GrailsPublishPluginSpec.groovy#L410 . For now, it has to exist in a root build.gradle.
|
Superseeded by #170 |
No description provided.