Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ROS connection issue on IronPython #126

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

gonzalocasas
Copy link
Member

@gonzalocasas gonzalocasas commented Jan 19, 2025

Fixed ROS connection issue mentioned here https://forum.compas-framework.org/t/failed-to-build-connection-between-ros-backend-and-rhino-7/960/8

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke check).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas
Copy link
Member Author

@chenkasirer I will go ahead and merge this fix because it seems to be quite urgent, but if you see anything worrying about it, please let me know

@gonzalocasas gonzalocasas merged commit e994fe2 into main Jan 19, 2025
8 checks passed
@gonzalocasas gonzalocasas deleted the fix-cli-connect-issue branch January 19, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant