Always provide const values for rust #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bluenote10 I am quite sure that this will not break anything. but can you have a look. |
bluenote10
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
This looks good to me, and I can confirm that there is no breaking change:
Nitpick: I would have generated these pub const FAUST_XXX expressions somewhere at the top of the file instead of the very bottom, because such constants are traditionally placed more in the "header" area of a file (and the other PR also places the FaustFloat alias on top, which plays a similar role).
crop2000
force-pushed
the
rust_always_const
branch
from
8e07888
to
829693a
Compare
|
I moved the const definition just before the struct definition. |
This commit removes the -uim flag for rust and provides the const values by default and makes use of these const values in get_num_inputs and get_num_outputs it also simplifies how this functions are generated they are now just a string
crop2000
force-pushed
the
rust_always_const
branch
from
829693a
to
00a54c7
Compare
|
@sletz are you open to merge this? |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the -uim flag for rust
and provides the const values by default
and makes use of these const values
in get_num_inputs and get_num_outputs
it also simplifies how this functions are generated they are now just a string
To create arrays for compute_arrays() one needs to know the array sizes at compile time. The const definitions provide these.