Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WWII draft registration fields #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jmuccigr
Copy link

added missing fields & corrected a few others.

added missing fields & corrected a few others.
@Caulley
Copy link

Caulley commented Jun 10, 2022

This Form need a complete re-wright. When I created this form I was under the impression that there was only 1 card. There were 6 cards. The form need to be rewritten in a nondestructive manure.

@Caulley
Copy link

Caulley commented Jul 25, 2022

A revised version of the form is at /World%20War%20II%20Draft%20Registration%20Card. If someone/anyone/everyone could take a look at it and make suggestions to improve it would be helpful.

@hgohel
Copy link
Member

hgohel commented Jul 28, 2024

A revised version of the form is at /World%20War%20II%20Draft%20Registration%20Card. If someone/anyone/everyone could take a look at it and make suggestions to improve it would be helpful.

@Caulley Could you provide a full link to the form? Thanks.
[Update] Perhaps you're referring to the form that contains the changes in this PR? i.e. the form starting at line 7815?

@Caulley
Copy link

Caulley commented Jul 30, 2024

Link to the form https://github.com/Caulley/Gramps-form_us/blob/main/World%20War%20II%20Draft%20Registration%20Card#L1

@GaryGriffin
Copy link
Member

I am confused by this change.

First, it is against master branch. It should be against gramps52.

Second, the differences in the PR includes one field Place of employment or business (Address), so breaks existing forms. BUT this change is not consistent with gramps52 branch. gramps52 has the (Address) portion of the field name.

Third, when I use the form provided in the previous Comment, it appears to not break existing form entries. So that specific form change seems okay.

What I see is some additional fields (citizenship, occupation, ...) . I don't have any real examples using these new fields, so I cannot confirm that the update matches all of the WW2 DRC forms. All of my examples use the simple form that is in the original Form layout.

I think this PR needs to be closed and reopened against gramps52 and use the form_us.xml which would include the revised WW2DRC portion. Then we can test it for merging.

@Caulley
Copy link

Caulley commented Jul 30, 2024

Examples of the draft cards can be found here - https://drive.google.com/drive/folders/1h2h23yhgT6V1Do6vqcGMqr2FvcoA0KA7?usp=drive_link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants