Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] recurring_consignment: do not delete all pricelist items, if new product.template is created. #184

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

legalsylvain
Copy link
Member

That was the case, due to a misunderstood of browse function, that returns all items if template_ids is null.

…w product.template is created.

That was the case, due to a misunderstood of browse function, that returns all items if template_ids is null.
@legalsylvain legalsylvain added this to the 16.0 milestone Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.35%. Comparing base (675aaa1) to head (0dd4a45).

Files with missing lines Patch % Lines
recurring_consignment/models/product_template.py 45.45% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             16.0     #184   +/-   ##
=======================================
  Coverage   89.34%   89.35%           
=======================================
  Files          93       93           
  Lines        1145     1146    +1     
  Branches      108      109    +1     
=======================================
+ Hits         1023     1024    +1     
  Misses         91       91           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant