Lingering issues for Public Release #86

[josiahseaman]

This is our final bug fix round before public release. It deserves lots of testing. If you can find time, please test and leave us review comments on GitHub.

[6br]

Thank you for implementation!
I'd like to try this branch, but yarn start cannot show anything...
I'd be glad if there is any instruction to visualize sars_covid dataset on this branch.

[6br]

Just for curiosity's sake, is it possible to update a konva or react-script version to the latest?
I saw some vulnerabilities on react-script dependency.

[6br]

I found minor thing when I set row number as 1.

[6br]

I found an awkward behaviour when I click bin link on bin_width != 1.

[josiahseaman]

I'm going to start trying to reproduce this error now. I'm on commit 78bd415

[6br]

I'm afraid that the latest commit cannot read any bin2file.json. I think this is due to the packages update.

[josiahseaman]

Maybe you didn't npm start again. I accidentally did that this morning.

[josiahseaman]

It was very difficult to reproduce the bug, but I finally got it by throttling my internet connection. It appears to be a race condition while navigating at the same time you're updating your bin width zoom level. I think it's sufficient to just fail silently in this case and trigger a re-render.

[6br]

I found the reason. The requested URL was http://localhost:3000/Schematizetest_data/SARS-CoV-b/bin2file.json. This is called from tryJSONpath function. This function needs to be fixed.

From

    function tryJSONpath(event) {
      const url =
        process.env.PUBLIC_URL +
        "test_data/" +
        event.target.value +
        "/bin2file.json";
      if (urlExists(url)) {
        console.log("STEP#1: New Data Source: " + event.target.value);
        self.jsonName = event.target.value;
      }

To

    function tryJSONpath(event) {
      const url =
        process.env.PUBLIC_URL +
        "/test_data/" +
        event.target.value +
        "/bin2file.json";
      if (urlExists(url)) {
        console.log("STEP#1: New Data Source: " + event.target.value);
        self.jsonName = event.target.value;
      }

The prefix "/" is needed on "test_data/"

[josiahseaman]

I just pushed a commit with both of those fixes. See if you can reproduce the link bug.

[6br]

It was very difficult to reproduce the bug, but I finally got it by throttling my internet connection. It appears to be a race condition while navigating at the same time you're updating your bin width zoom level. I think it's sufficient to just fail silently in this case and trigger a re-render.

Certainly, I agree to leave it as.

[6br]

I just pushed a commit with both of those fixes. See if you can reproduce the link bug.

These bugs are now solved. Thank you!