Fixed goroutine leak in subscriptions (#626)

graph-gophers · Nov 28, 2023 · a226fe8 · a226fe8
1 parent 12e9b90
commit a226fe8
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/subscriptions.go b/subscriptions.go
@@ -76,10 +76,14 @@ func (s *Schema) subscribe(ctx context.Context, queryString string, operationNam
 	responses := r.Subscribe(ctx, res, op)
 	c := make(chan interface{})
 	go func() {
+	Loop:
 		for resp := range responses {
-			c <- &Response{
-				Data:   resp.Data,
-				Errors: resp.Errors,
+			select {
+			case c <- &Response{Data: resp.Data, Errors: resp.Errors}:
+				continue
+
+			case <-ctx.Done():
+				break Loop
 			}
 		}
 		close(c)