Open
Conversation
Lift isExpanded state from RoutingResult to parent RoutingResults component so it survives when child components re-mount after adding via points or recalculating routes. Also use stable path-derived keys instead of array indices for React reconciliation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This is awesome! 🎂 |
Contributor
|
Just one minor thing to make it production ready: 
Would it be possible to use the same colors in the left statistics and in the Legend? It seems the statistics colors are manually tuned, so these should also be used in the Legend. |
Mostly micro-optimizations: - ElevationInfoBar: throttle hover dispatches to once per animation frame - ChartRenderer: skip resize when dimensions unchanged - ElevationWidget: floor fractional ResizeObserver widths; add touch handlers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Return same state reference in PathDetailsStore when SetActiveDetail dispatches the same detail. Without this, the spread operator creates a new object every time, which passes Store's reference equality check and triggers a re-render loop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More insights into routes, especially bike routes is very valuable.
Especially when tuning them. And so I always wanted to create some statistic overview per route. And as this is not only useful for developers but also for users I thought I would integrate it directly in GH Maps (click "Details").
Try it here.
TODO