-
Notifications
You must be signed in to change notification settings - Fork 27
Update to CUDA 13.0 and fix logging initialization error #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
aucahuasi
commented
Nov 23, 2025
- Upgrade base image from v2.43.0-12.8 to v2.50.0-13.0
- Update CI workflows to build CUDA 13.0 and 12.9 versions
- Change conda environment activation from rapids to base
- Fix AttributeError when LOG_LEVEL=TRACE by mapping unsupported log levels (TRACE, VERBOSE) to DEBUG with stderr warning
- Upgrade base image from v2.43.0-12.8 to v2.50.0-13.0 - Update CI workflows to build CUDA 13.0 and 12.9 versions - Change conda environment activation from rapids to base - Fix AttributeError when LOG_LEVEL=TRACE by mapping unsupported log levels (TRACE, VERBOSE) to DEBUG with stderr warning
lmeyerov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For changing hard-coded evals, let's wait to land till current release goes out etc as we get into an awkward release posture
Another thought to land sooner and streamline going forward: Instead of manually changing constants identified here, if we make them variables set by the caller or passed in, then we can land whenever. Most of these are already args to beginwith. They can still default to old version, and the test is if the new version grabs the expected new passed in vals...
|
Thanks for reviewing this PR!
I didn't change any harcoded evals there, all those are params and I just updated their default values.
Yes, indeed! This is the case here, those were always vars/params used by the parent job to build. |
|
Yes, I' saying instead of changing defaults here and relying on defaults, do not change any defaults here, and make the calling code branch (graphistry/graphistry) pass in the right things. Then we can land this whenever, and graphistry master can keep working too b/c old defaults still active. We may still be relying on some hard-coded defaults here somewhere, if this pr can work on the new versions without any default val changes here, then we have better confidence it works and can land sooner, and less risk of being unable to patch release old versions |
Got it, good catch, let me think how we can handle the CUDA (11.8,12.8) vs (13.0,12.9) mismatch. |
|
Let's just wait until we finish the release so we can push this RAPIDS 25.10/CUDA13 branch after that. |
I did this other PR #127 that allow us to pass cuda versions as args, once we merged that we will be able to support current branches and new rapids branches as well. |