Add "substreams/triggers" kind for substreams datasource mapping#5627
Add "substreams/triggers" kind for substreams datasource mapping#5627YaroShkvorets wants to merge 1 commit intographprotocol:masterfrom
Conversation
|
This pull request hasn't had any activity for the last 90 days. If there's no more activity over the course of the next 14 days, it will automatically be closed. |
|
What is the difference between this new type and the old type conceptually? Just that this one requires a handler that is optional on the other type? Is that worth maintaining (and documenting, etc) yet another type? Has support for this been added to graph-cli? That should be the first step for changes like this since ideally any validation should happen during compilation time. Unfortunately for the time being this validation has to be implemented in both places. All that being said, I don't really see a benefit to introducing this definition, plus it should be properly documented and validated by all components if it is to be created. |
We had a discussion with @abourget on Slack that
substreams/graph-entitieskind doesn't make sense for trigger-based SbS.This PR adds new kind
substreams/triggers.Data source mapping of this kind requires both
fileandhandlerdefined in the manifest