Skip to content

Comments

Add "substreams/triggers" kind for substreams datasource mapping#5627

Closed
YaroShkvorets wants to merge 1 commit intographprotocol:masterfrom
YaroShkvorets:yaro/kind_substreams_triggers
Closed

Add "substreams/triggers" kind for substreams datasource mapping#5627
YaroShkvorets wants to merge 1 commit intographprotocol:masterfrom
YaroShkvorets:yaro/kind_substreams_triggers

Conversation

@YaroShkvorets
Copy link
Contributor

We had a discussion with @abourget on Slack that substreams/graph-entities kind doesn't make sense for trigger-based SbS.
This PR adds new kind substreams/triggers.
Data source mapping of this kind requires both file and handler defined in the manifest

Copy link
Contributor

@sduchesneau sduchesneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

This pull request hasn't had any activity for the last 90 days. If there's no more activity over the course of the next 14 days, it will automatically be closed.

@github-actions github-actions bot added the Stale label Dec 10, 2024
@github-actions github-actions bot closed this Jan 28, 2025
@alex-pakalniskis alex-pakalniskis added enhancement New feature or request and removed Stale labels Jan 29, 2025
@mangas
Copy link
Contributor

mangas commented Jan 29, 2025

What is the difference between this new type and the old type conceptually? Just that this one requires a handler that is optional on the other type? Is that worth maintaining (and documenting, etc) yet another type?

Has support for this been added to graph-cli? That should be the first step for changes like this since ideally any validation should happen during compilation time. Unfortunately for the time being this validation has to be implemented in both places.

All that being said, I don't really see a benefit to introducing this definition, plus it should be properly documented and validated by all components if it is to be created.

Copy link
Contributor

@mangas mangas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@fordN fordN closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants