Merged
Conversation
979a7c0 to
5e0e744
Compare
mangas
reviewed
Jan 9, 2025
mangas
reviewed
Jan 9, 2025
5e0e744 to
9a6f1f0
Compare
9a6f1f0 to
c202a6d
Compare
mangas
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
deployment_statusmetric with the following behavior:deployment_statusis set to1(starting);deployment_statusis set to2(running);deployment_statusis set to3(stopped);deployment_statusis set to4(failed);deployment_statusis set back to2(running);No other values for
deployment_statusshould be expected.Closes #5405
Breaking changes
The
deployment_failedmetric is removed and the failures are reported by the newdeployment_statusmetric.Node operators that relied on
deployment_failedshould switch to usingdeployment_status.Testing
The new metric was tested on a local graph-node and Prometheus setup. I have tested various scenarios such as errors, pauses, restarts and the metric behaves as expected and reports correct values.