Closed
Conversation
The code assumed one column too few when calculating chunk size which can cause errors
Collaborator
Author
|
This was actually merged at commit 63ea9d7. Not sure why github is showing this as closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inserting entities during subgraph syncing, we split the entities that need to be written into chunks which we want to be as large as possible for best performance. Since Postgres only allows using 65k bind variables, the number of entities we can insert in one chunk is roughly 65k/#columns. The code did not account for the
causality_regionwhen calculating the number of columns to be inserted.Since we had issues with this calculations in the past and it's next to impossible for operators to work around it, this also introduces an environment variable
GRAPH_STORE_INSERT_EXTRA_COLSthat operators can use to work around this issue should we ever screw up this calculation again.