Changes to VID generation after rebase with master#5815
Closed
zorancv wants to merge 3 commits intozoran/rework-vid-wrap2-before-rebasefrom
Closed
Changes to VID generation after rebase with master#5815zorancv wants to merge 3 commits intozoran/rework-vid-wrap2-before-rebasefrom
zorancv wants to merge 3 commits intozoran/rework-vid-wrap2-before-rebasefrom
Conversation
zorancv
changed the base branch from
master
to
zoran/rework-vid-wrap2-before-rebase
lutter
approved these changes
Feb 11, 2025
| AttributeNames::All => { | ||
| cols.extend(self.meta.columns.iter()); | ||
| cols.push(&*VID_COL); | ||
| } |
Collaborator
There was a problem hiding this comment.
Don't we have to include the VID_COL no matter what column_names is?
Contributor
Author
There was a problem hiding this comment.
I was not sure as this match side is the only one used. I've changed it to be always be added. Since this is already merged I've addressed it in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.