Conversation
added 2 commits
February 12, 2025 15:24
lutter
approved these changes
Feb 13, 2025
Collaborator
lutter
left a comment
lutter
left a comment
There was a problem hiding this comment.
Nice! This is good to go after addressing that one minor comment
| out.unsafe_to_cache_prepared(); | ||
|
|
||
| let strict_vid_order = self.table.object.strict_vid_order(); | ||
| let strict_vid_order = self.table.object.has_vid_seq(); |
Collaborator
There was a problem hiding this comment.
Very minor, but this variable should also be called has_vid_seq
Contributor
Author
There was a problem hiding this comment.
Same with the variable bellow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing some of the remaining remarks in regards to the VIDs.