Skip to content

Comments

server/graphman: Fix failing test#5832

Closed
lutter wants to merge 1 commit intomasterfrom
lutter/graphql-test
Closed

server/graphman: Fix failing test#5832
lutter wants to merge 1 commit intomasterfrom
lutter/graphql-test

Conversation

@lutter
Copy link
Collaborator

@lutter lutter commented Feb 18, 2025

I am not 100% sure that this is the right fix for that test, but it was failing for me locally.

I would also suggest that the response when it has warnings should contain success data, i.e., that it looks something like

"data": {
  "deployment": {
    "reassign": {
      "success": true,
      "warnings": ["..."],
    }  }  }

@isum @shiyasmohd Would love your take on that.

@isum
Copy link
Member

isum commented Feb 18, 2025

The issue will be fixed by #5834

@isum isum closed this Feb 18, 2025
@lutter lutter deleted the lutter/graphql-test branch April 17, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants