Add retries for FirehoseEndpoint::load_blocks_by_numbers#5838
Merged
incrypto32 merged 1 commit intomasterfrom Feb 21, 2025
Merged
Add retries for FirehoseEndpoint::load_blocks_by_numbers#5838incrypto32 merged 1 commit intomasterfrom
incrypto32 merged 1 commit intomasterfrom
Conversation
incrypto32
force-pushed
the
krishna/sc-firehose-retries
branch
5 times, most recently
from
544b50c to
ddb28a2
Compare
zorancv
approved these changes
Feb 21, 2025
Contributor
zorancv
left a comment
zorancv
left a comment
There was a problem hiding this comment.
Besides the uncertainty of a need for pining, the rest looks fine.
graph/src/firehose/endpoints.rs
Outdated
| .run(move || { | ||
| let e = endpoint_for_retry.cheap_clone(); | ||
| let l = logger_for_retry.clone(); | ||
| Box::pin(async move { e.get_block_by_number::<M>(number, &l).await }) |
Contributor
There was a problem hiding this comment.
Probably a silly question, but why is pinning needed here?
Member
Author
There was a problem hiding this comment.
Thanks for pointing, out. It was a leftover from when i moved the method elsewhere. Updated
incrypto32
force-pushed
the
krishna/sc-firehose-retries
branch
from
ddb28a2 to
fe5db3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.