Merged
Conversation
mangas
force-pushed
the
filipe/fix-substreams-info-endpoint
branch
3 times, most recently
from
cc96be6 to
082de01
Compare
mangas
force-pushed
the
filipe/fix-substreams-info-endpoint
branch
from
082de01 to
b627dd3
Compare
isum
reviewed
Feb 26, 2025
graph/src/firehose/endpoints.rs
Outdated
Comment on lines
84
to
90
| let pred = if info.chain_name.contains("arbitrum") { | ||
| |x| x == "extended" || x == "hybrid" | ||
| } else { | ||
| |x| x == "extended" | ||
| }; | ||
|
|
||
| Ok(info.block_features.iter().all(|x| x == "extended")) | ||
| Ok(info.block_features.iter().all(pred)) |
Member
There was a problem hiding this comment.
I am not sure if this will work as expected. For example, arbone.firehose.pinax.network:443 returns only block_features: ["hybrid"] which is fine, but arb-one.streamingfast.io:443 returns block_features: ["hybrid", "extended@22207818"] which will not pass the test.
You can replace the .all() call with .any(), or update the check to |x| x == "hybrid" || x == "extended" || x.starts_with("extended@") but event this may not cover all the differences in the Firehose responses.
mangas
force-pushed
the
filipe/fix-substreams-info-endpoint
branch
from
b627dd3 to
1934881
Compare
isum
approved these changes
Feb 26, 2025
mangas
force-pushed
the
filipe/fix-substreams-info-endpoint
branch
2 times, most recently
from
5740f22 to
8815786
Compare
mangas
force-pushed
the
filipe/fix-substreams-info-endpoint
branch
from
8815786 to
c599f70
Compare
encalypto
added a commit
that referenced
this pull request
Mar 28, 2025
This reverts commit 6d46576.
encalypto
added a commit
that referenced
this pull request
Mar 28, 2025
This reverts commit 6d46576.
encalypto
added a commit
that referenced
this pull request
Mar 31, 2025
This reverts commit 6d46576.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.