Stop pretending that there are subgraphs that don't support PoI#5863
Merged
Stop pretending that there are subgraphs that don't support PoI#5863
Conversation
mangas
approved these changes
Mar 6, 2025
Contributor
mangas
left a comment
mangas
left a comment
There was a problem hiding this comment.
Loving the hate driven development
Subgraphs have in fact supported proof of indexing for almost 5 years since commit 40fd330 and we can therefore stop pretending that that method would ever return `false`
This brings a small amount of sanity to the code using that.
lutter
force-pushed
the
lutter/poi-support
branch
from
ee427c8 to
8687ada
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subgraphs have in fact supported proof of indexing for almost 5 years since commit 40fd330 and we can therefore stop pretending that
WritableStore.supports_proof_of_indexingwould ever returnfalse