Conversation
zorancv
force-pushed
the
zoran/fix-reorg-threshold-bug2
branch
from
3c14f38 to
ddc9eac
Compare
lutter
approved these changes
Apr 11, 2025
Collaborator
lutter
left a comment
lutter
left a comment
There was a problem hiding this comment.
Nice, I like how this turned out
|
|
||
| lazy_static! { | ||
| pub static ref ENV_VARS: EnvVars = EnvVars::from_env().unwrap(); | ||
| pub static ref TEST_WITH_NO_REORG: Mutex<bool> = Mutex::new(false); |
Collaborator
There was a problem hiding this comment.
This is minor, but I think we could also compile this out with #[cfg(not(debug_assertions))]
zorancv
force-pushed
the
zoran/fix-reorg-threshold-bug2
branch
from
a4d8bc9 to
1b1b6a3
Compare
zorancv
force-pushed
the
zoran/fix-reorg-threshold-bug2
branch
from
1b1b6a3 to
1fd774a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the review comments from #5804 and squashed previous commits to one verified commit.