Skip to content

node: Accept a bare number as a deployment id in graphman #5954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lutter merged 1 commit into from
Apr 21, 2025
Merged

node: Accept a bare number as a deployment id in graphman #5954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions node/src/manager/deployment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ lazy_static! {
// `Qm...` optionally follow by `:$shard`
static ref HASH_RE: Regex = Regex::new("\\A(?P<hash>Qm[^:]+)(:(?P<shard>[a-z0-9_]+))?\\z").unwrap();
// `sgdNNN`
static ref DEPLOYMENT_RE: Regex = Regex::new("\\A(?P<nsp>sgd[0-9]+)\\z").unwrap();
static ref DEPLOYMENT_RE: Regex = Regex::new("\\A(?P<nsp>(sgd)?[0-9]+)\\z").unwrap();
}

/// A search for one or multiple deployments to make it possible to search
Expand Down Expand Up @@ -58,7 +58,12 @@ impl FromStr for DeploymentSearch {
Ok(DeploymentSearch::Hash { hash, shard })
} else if let Some(caps) = DEPLOYMENT_RE.captures(s) {
let namespace = caps.name("nsp").unwrap().as_str().to_string();
Ok(DeploymentSearch::Deployment { namespace })
if namespace.starts_with("sgd") {
Ok(DeploymentSearch::Deployment { namespace })
} else {
let namespace = format!("sgd{namespace}");
Ok(DeploymentSearch::Deployment { namespace })
}
} else {
Ok(DeploymentSearch::Name {
name: s.to_string(),
Expand Down
Loading