Skip to content

graphql: Avoid cloning a list #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lutter merged 1 commit into from
May 15, 2025
Merged

graphql: Avoid cloning a list #6007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions graphql/src/store/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,25 +388,19 @@ fn build_child_filter_from_object(
/// Parses a list of GraphQL values into a vector of entity field values.
fn list_values(value: Value, filter_type: &str) -> Result<Vec<Value>, QueryExecutionError> {
match value {
Value::List(ref values) if !values.is_empty() => {
Value::List(values) => {
// Check that all values in list are of the same type
let root_discriminant = discriminant(&values[0]);
values
.iter()
.map(|value| {
let current_discriminant = discriminant(value);
if root_discriminant == current_discriminant {
Ok(value.clone())
} else {
Err(QueryExecutionError::ListTypesError(
filter_type.to_string(),
vec![values[0].to_string(), value.to_string()],
))
}
})
.collect::<Result<Vec<_>, _>>()
for value in &values {
if root_discriminant != discriminant(value) {
return Err(QueryExecutionError::ListTypesError(
filter_type.to_string(),
vec![values[0].to_string(), value.to_string()],
));
}
}
Ok(values)
}
Value::List(ref values) if values.is_empty() => Ok(vec![]),
_ => Err(QueryExecutionError::ListFilterError(
filter_type.to_string(),
)),
Expand Down