Fix all cargo check warnings and enforce zero-warning requirement#6101
Merged
Fix all cargo check warnings and enforce zero-warning requirement#6101
Conversation
Fixes all 16 cargo check warnings across the codebase: **Cargo.toml fixes:** - Remove invalid `doc = false` key from git dependency **Dead code warnings:** - Add #[allow(dead_code)] to reference implementations and test utilities - PoI struct and helper functions (proof_of_indexing/reference.rs) - AscSubgraphEntityOp enum (runtime/wasm) - CopyVid struct (store/postgres) **Lifetime syntax warnings:** - Add explicit '_ lifetime parameters to fix confusing syntax - Fix 11 lifetime warnings across store, runtime, and utility modules **Documentation updates:** - Update CLAUDE.md to make `cargo check` mandatory alongside tests - Establish clear success criteria: tests pass + zero warnings + formatting - Add stronger enforcement language for code quality requirements All tests pass and cargo check now produces zero warnings. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
fubhy
force-pushed
the
fix-cargo-check-warnings
branch
from
d5b70b5 to
58e107e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 cargo check warnings across the codebase and updates CLAUDE.md to make
cargo checka mandatory requirement for all implementations.Changes Made
🔧 Cargo.toml Fix (1 warning)
doc = falsekey fromstable-hash_legacygit dependency🔕 Dead Code Warnings (4 warnings)
#[allow(dead_code)]to reference implementations and test utilities:PoIstruct and helper functions inproof_of_indexing/reference.rsAscSubgraphEntityOpenum inruntime/wasmCopyVidstruct instore/postgres⏰ Lifetime Syntax Warnings (11 warnings)
'_lifetime parameters to fix confusing syntax across:graph/src/components/store/write.rs(2 fixes)graph/src/util/timed_rw_lock.rs(4 fixes)runtime/wasm/src/module/instance.rs(1 fix)store/postgresfiles (4 fixes)📚 Documentation Updates
cargo checkmandatory alongside testsValidation
✅
cargo checknow produces zero warnings✅ All existing tests continue to pass
✅ Code is properly formatted
New Development Requirements
Going forward, ALL implementations must satisfy:
cargo checkMUST show zero warningscargo fmt --allMUST be run after editing ANY .rs fileThis ensures consistent code quality and prevents warnings from accumulating in the codebase.
🤖 Generated with Claude Code