Conversation
fubhy
force-pushed
the
update-to-pnpm-workspace
branch
14 times, most recently
from
e8c6619 to
b54193c
Compare
fubhy
force-pushed
the
update-to-pnpm-workspace
branch
from
b54193c to
c74671d
Compare
fubhy
changed the title
fubhy
force-pushed
the
update-to-pnpm-workspace
branch
2 times, most recently
from
f43f935 to
9232e65
Compare
fubhy
force-pushed
the
update-to-pnpm-workspace
branch
from
9232e65 to
9075ddc
Compare
This was referenced Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current setup with
yarnhas Node module resolution issues and therefore produces other WASM hashes and subgraph hashes. This can be replicated also inyarnby installing the package seperately instead of via the yarn workspace (produces the same output aspnpmin that case).E.g. for the test
static_filters_false_positives:QmWgKfybDi2bMgvzMhhhGR49KJ2jFdUxMdnYs8DUfPcj1cQmSfWeRwMvR1xdPamvBwB8yab6dauW5nwh84Kcefy6fgqBQmbnJnVwV9DDcHRiUr6n1TQ3foMkSD9C9UtyXuiLYrNDoEQmaQ5cE7a7YriKDs1ysFDwGgfqhmsnu1XJb9dAWyHPCavB8e5cfe3f014586cf0f02277c306ac66f11da52b632b937bd74229cce1374d9d5c72af01a19a4e35a35778821a354b7a781062a9320ac8796ea65b115cb9844bfI have therefore updataed the POI hash assertion in the test suite where applicable. ./cc @lutter
NOTE: The new (pnpm) setup uses the correct versions. This was a bug / is a bug in the current setup with yarn.