Conversation
lutter
force-pushed
the
lutter/pin-anvil
branch
from
665f77e to
1257683
Compare
It seems that anvil 1.2.3 is the last version to produce deterministic block hashes reliably. The 'grafted' test really needs deterministic block hashes as they influence the PoI which this test checks. If [this foundry bug](foundry-rs/foundry#9570) gets fixed, we should try again with latest stable foundry.
lutter
force-pushed
the
lutter/pin-anvil
branch
from
1257683 to
6ffad00
Compare
fubhy
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that anvil 1.2.3 is the last version to produce deterministic block hashes reliably. The 'grafted' test really needs deterministic block hashes as they influence the PoI which this test checks.
If this foundry bug gets fixed, we should try again with latest stable foundry.
I spent way too much time trying to work around the nondeterministic block hashes - anything we can do there is way grosser and more brittle than just pinning anvil until upstream is fixed and makes block hashes deterministic.