Fix import.meta.url not being parsed as path properly#1903
Merged
YaroShkvorets merged 4 commits intographprotocol:mainfrom Jan 21, 2025
Merged
Fix import.meta.url not being parsed as path properly#1903YaroShkvorets merged 4 commits intographprotocol:mainfrom
import.meta.url not being parsed as path properly#1903YaroShkvorets merged 4 commits intographprotocol:mainfrom
Conversation
Using `import.meta.url` to resolve local file path and directories can lead to issues when special characters are percent-encoded in the url. This fix uses the `fileURLToPath` native method to properly parse local urls to file paths.
🦋 Changeset detectedLatest commit: 85e72bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
incrypto32
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Fix `import.meta.url` not being parsed as path properly Using `import.meta.url` to resolve local file path and directories can lead to issues when special characters are percent-encoded in the url. This fix uses the `fileURLToPath` native method to properly parse local urls to file paths. * Add changeset * Remove regex and adjust path * remove unnecessary platform check --------- Co-authored-by: YaroShkvorets <shkvorets@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
import.meta.urlto resolve local file path and directories can lead to issues when special characters are percent-encoded in the url.This fix uses the
fileURLToPathnative method to properly parse local urls to file paths.Closes #1881