Emit a warning when data sources have duplicate functionality#556
Open
Emit a warning when data sources have duplicate functionality#556
Conversation
fordN
changed the title
Collaborator
Author
|
This is currently setup to emit a warning, but I'm now thinking we should fail the subgraph on this condition. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes an additional check during subgraph validation to identify data sources which are functionally equivalent.
If a subgraph is deployed with functionally equivalent data sources it will likely lead to unexpected entity data such as double counting.