chore: cleanup exports #34
Conversation
🦋 Changeset detectedLatest commit: 9b886cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikgraf
force-pushed
the
ng/cleanup-exports
branch
from
035bc39 to
9725795
Compare
nikgraf
force-pushed
the
ng/cleanup-exports
branch
from
9725795 to
add1f17
Compare
|
@baiirun I updated the readme 👍 |
There was a problem hiding this comment.
Approved but had a question on whether we should go ahead and add a namespace for the base58 utilities.
Note that these are pretty breaking changes and we already have a few repos relying on this package. Namely the web app and the hackathon template. I'll update those once this gets merged in and a new version published.
index.ts
Outdated
|
|
||
| /** | ||
| * This module provides utility functions for working with base58 ids | ||
| * in TypeScript. | ||
| * | ||
| * @since 0.0.6 | ||
| */ | ||
| export { BASE58_ALLOWED_CHARS, decodeBase58ToUUID, encodeBase58 } from './src/core/base58.js'; | ||
| export { decodeBase58ToUUID, encodeBase58 } from './src/core/base58.js'; |
There was a problem hiding this comment.
Does it make sense to Namespace these as part of this PR?
There was a problem hiding this comment.
agreed, just added a commit. In this case I think it's also fine to expose BASE58_ALLOWED_CHARS
No description provided.