Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to NET8 #382

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Migrate to NET8 #382

merged 4 commits into from
Dec 11, 2023

Conversation

sungam3r
Copy link
Member

No description provided.

@sungam3r sungam3r requested a review from Shane32 December 11, 2023 09:18
@@ -73,7 +71,7 @@ jobs:
if: ${{ startsWith(matrix.os, 'ubuntu') }}
uses: codecov/codecov-action@v3
with:
files: .coverage/GraphQLParser.Tests/coverage.net5.opencover.xml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a bug.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v8@8de2491). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             v8     #382   +/-   ##
=====================================
  Coverage      ?   96.12%           
=====================================
  Files         ?       89           
  Lines         ?     5004           
  Branches      ?      473           
=====================================
  Hits          ?     4810           
  Misses        ?      192           
  Partials      ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shane32 Shane32 merged commit aa5475e into v8 Dec 11, 2023
6 checks passed
@Shane32 Shane32 deleted the net8 branch December 11, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants