Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid HTML #1129

Closed
Kowjako opened this issue Apr 26, 2024 · 2 comments · Fixed by #1131
Closed

Invalid HTML #1129

Kowjako opened this issue Apr 26, 2024 · 2 comments · Fixed by #1131
Milestone

Comments

@Kowjako
Copy link
Contributor

Kowjako commented Apr 26, 2024

I have a problem, when i use
app.UseGraphQLGraphiQL("/ui/graphiql", new () { ExplorerExtensionEnabled = false });

Then i have a weird double lupe on Docs section, if i will not specify this then i dont have access to modify headers.
Please solve it, its looking terrible

@Kowjako
Copy link
Contributor Author

Kowjako commented Apr 26, 2024

image

@Shane32
Copy link
Member

Shane32 commented Apr 26, 2024

The page is generated from this:

https://github.com/graphql-dotnet/server/blob/master/src/Ui.GraphiQL/Internal/graphiql.cshtml

Can you write a PR that includes the necessary changes to fix the page? Please note that the version provided by this middleware is GraphiQL 1.5.1, and the current version is GraphiQL 3.2.0. Perhaps updating the page to pull the latest version of GraphiQL would fix the issue.

Here is the link to the GraphiQL repository:

https://github.com/graphql/graphiql

@Shane32 Shane32 added this to the 8.0 milestone Aug 3, 2024
@Shane32 Shane32 linked a pull request Aug 3, 2024 that will close this issue
@Shane32 Shane32 closed this as completed Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants