Bump Graphiql to fix layout #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
reviewed
May 4, 2024
| @@ -52,8 +52,7 @@ | |||
| --> | |||
| <link | |||
| rel="stylesheet" | |||
| href="https://unpkg.com/graphiql@1.5.1/graphiql.min.css" | |||
| integrity="sha384-1YHEU+Xy8hlKYAZ26WTz+JQEPMM6i/Mx5m8umMkSZChlzSYmq7RqyCyRbGqrILVZ" | |||
| href="https://unpkg.com/graphiql/graphiql.min.css" | |||
There was a problem hiding this comment.
I think we should maintain a specific version tag and integrity hash.
Shane32
reviewed
May 4, 2024
| @@ -52,8 +52,7 @@ | |||
| --> | |||
| <link | |||
| rel="stylesheet" | |||
| href="https://unpkg.com/graphiql@1.5.1/graphiql.min.css" | |||
| integrity="sha384-1YHEU+Xy8hlKYAZ26WTz+JQEPMM6i/Mx5m8umMkSZChlzSYmq7RqyCyRbGqrILVZ" | |||
| href="https://unpkg.com/graphiql/graphiql.min.css" | |||
| crossorigin="anonymous" | |||
| /> | |||
| <script | |||
There was a problem hiding this comment.
On the next line there is a reference to graphiqlWithExtensions. Is this old version compatible with the new version of GraphiQL ? All other features still work?
There was a problem hiding this comment.
Yes, ive checked and it works as expected
|
Btw new Graphiql is awesome |
Shane32
approved these changes
Aug 3, 2024
Closed
|
@Kowjako will this PR enable the new GraphiQL 2.0? |
|
Yes, this PR has been merged for 8.x. It will bump GraphiQL to 3.2.0 |
|
Thanks, @Shane32 . We will be eagerly waiting for 8.x :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1129