Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable form post by default #1139

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Disable form post by default #1139

merged 3 commits into from
Aug 4, 2024

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Aug 4, 2024

Form post requests are not recommended, mostly due to CSRF concerns. Also the draft GraphQL-over-HTTP specification does not define the format of such a request. Since v7 we have stated that form post requests would be disabled by default in future versions. This PR disables form post requests by default.

@Shane32 Shane32 added this to the 8.0 milestone Aug 4, 2024
@Shane32 Shane32 self-assigned this Aug 4, 2024
@Shane32 Shane32 requested a review from gao-artur August 4, 2024 05:10
@Shane32 Shane32 linked an issue Aug 4, 2024 that may be closed by this pull request
@Shane32 Shane32 merged commit c48d21a into develop Aug 4, 2024
7 checks passed
@Shane32 Shane32 deleted the disable_form_post branch August 4, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable ReadFormOnPost by default
2 participants