Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1181

Merged
merged 11 commits into from
Jan 16, 2025
Merged

Fix CI #1181

merged 11 commits into from
Jan 16, 2025

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Jan 16, 2025

It seems that GitHub Actions' Linux runner has been updated with new versions of libssl and libicu (perhaps inherited from a new version of Ubuntu). However, .NET 2.1 and 3.1 are hard-coded to only support specific versions of those libraries. Long story short, after about 4 hours of work, I finally got the CI tests running again. In general:

  • Disabled .NET 2.1 and 3.1 and 5.0 tests when run on Linux
  • Disabled Azure Function library tests when run on Linux

Almost everything still gets tested on Windows and passes as before. It's just Linux that is having an issue. The Azure Function sample project is demonstrating the in-process configuration model. This model only runs on .NET 6 under Windows and will go out of support late 2026. Perhaps sometime we can update or add a sample for the out-of-process configuration model which supports .NET 8 and is the currently-recommended integration path for Azure Functions. Either way I believe Azure Functions always run under Windows, and so the fact that it cannot be tested on Linux is irrelevant.

As a reminder, ASP.NET Core 2.1 is still fully supported by MS on Windows when run under supported versions of the .NET Framework. I use this configuration for one of my projects. As such, I think it important to retain testing for ASP.NET Core 2.1 on the .NET Framework under Windows.

I'm fine if we need to drop testing for unsupported STS releases such as .NET 5.0 or old unsupported LTS releases such as .NET 3.1. However, to the degree that it is easy enough to configure the test runner to test these platforms, especially platforms that have recently fallen out of support, I feel there is no reason not to do so. As such, I've configured testing on as many of these platforms as will still run correctly.

The solution does provide a way to configure local testing to only use a single platform - configure the SingleTestPlatform msbuild property to true. Or just run the specific tests you require.

@Shane32 Shane32 self-assigned this Jan 16, 2025
@Shane32 Shane32 requested a review from gao-artur January 16, 2025 16:19
@Shane32 Shane32 merged commit 5e869ad into master Jan 16, 2025
13 checks passed
@Shane32 Shane32 deleted the fix_ci branch January 16, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants