-
-
Notifications
You must be signed in to change notification settings - Fork 206
Add Apollo Federation V2 support #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Apollo Federation V2 support #2900
Conversation
|
@dotansimha @ardatan Any chance this can be prioritized? |
|
Thanks @emileriksson ! I added 1 comment about the static schema, otherwise this look good to me. |
|
@emileriksson any idea why CI is failing with latest changes? 👀 I think that's the only blocker we have now |
|
Try trigger it again @dotansimha. The Node jobs go green when I ran this PR on my fork: emileriksson#2 |
|
Yeah, this seems great. Thank you @emileriksson. Can you please add a |
|
Awesome! I added a changeset file with minors to all affected packages @dotansimha 😄 |
|
Thanks @emileriksson ! Sorry for the additional requests, but two things came to mind when I discussed this with the team:
|
|
cc @jdolle |
Description
GraphQL Inspector don't support Federation V2. This PR adds the directives as well as a new argument
--federationV2to support this functionality.Fixes # (issue)
#2683
Type of change
How Has This Been Tested?
Test Environment:
@graphql-inspector/:Checklist:
CONTRIBUTING doc and the
style guidelines of this project