Include extra data in Meta in _meta #1328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianschneider94
force-pushed
the
extra-meta
branch
from
88720b3 to
d707459
Compare
|
Hey, could anyone have a look on this? |
|
Now the tests are broken... I have no idea, why... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
=======================================
Coverage 95.44% 95.45%
=======================================
Files 49 49
Lines 1582 1583 +1
=======================================
+ Hits 1510 1511 +1
Misses 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erikwrede
requested changes
Aug 27, 2022
| @@ -43,6 +43,7 @@ def __init_subclass_with_meta__( | |||
| return | |||
| _meta.name = name or cls.__name__ | |||
| _meta.description = description or trim_docstring(cls.__doc__) | |||
| _meta.extra = _kwargs | |||
There was a problem hiding this comment.
I think the extra field should be an explicit class attribute of the BaseOptions class so that it can be properly documented. Otherwise users will be confused about the meaning or the purpose/won't find it at all. LMK what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building an authorization middleware and I want to include functions/data in the Meta class to store the relevant information in the class itself.
However, all custom args in Meta are dropped at the moment.
I think there shouldn't be an issue to include other args in an extra attribute of _meta.