Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Remove query, variables, headers and response props in <GraphiQL />, <GraphiQLProvider /> and <EditorContextProvider /> #3735

Draft
wants to merge 3 commits into
base: graphiql-v4
Choose a base branch
from

Conversation

dimaMachina
Copy link
Collaborator

per proposition #3441 (comment)

Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: d2daab6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphiql/react Major
graphiql Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.21%. Comparing base (3a2580e) to head (d2daab6).
Report is 19 commits behind head on graphiql-v4.

Files with missing lines Patch % Lines
packages/graphiql-react/src/editor/context.tsx 63.63% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           graphiql-v4    #3735      +/-   ##
===============================================
- Coverage        67.26%   67.21%   -0.05%     
===============================================
  Files              120      120              
  Lines             7019     7018       -1     
  Branches          2268     2275       +7     
===============================================
- Hits              4721     4717       -4     
- Misses            2281     2284       +3     
  Partials            17       17              
Files with missing lines Coverage Δ
packages/graphiql-react/src/editor/hooks.ts 37.50% <ø> (-0.88%) ⬇️
packages/graphiql-react/src/provider.tsx 100.00% <ø> (ø)
packages/graphiql/src/components/GraphiQL.tsx 78.38% <ø> (ø)
packages/graphiql-react/src/editor/context.tsx 73.80% <63.63%> (-2.62%) ⬇️

Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, human-facing

.changeset/nasty-cows-train.md Outdated Show resolved Hide resolved
packages/graphiql/cypress/e2e/headers.cy.ts Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@klippx
Copy link
Contributor

klippx commented Aug 19, 2024

Not sure I want this change. I need this, since I am deep linking into our graphiql with a payload from query params. I decode this state and it contains query, variables and headers, and the editor must open in this state.

Would be good to see a migration path how to solve this if this API is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants