Editorial: Define _response map_ #1143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
benjie
reviewed
Mar 6, 2025
This creates a definition for Response Map, defined as the map normally returned by graphql queries and mutations containing data and/or errors. The definition of Response is updated to include both Response Map, and Response Stream (for subscriptions). For Incremental Delivery I plan on updating Response to also include _Incremental Stream_.
robrichard
force-pushed
the
robrichard/response-map
branch
from
9e0af97 to
00fe58d
Compare
benjie
approved these changes
Mar 6, 2025
Co-authored-by: Benjie <benjie@jemjie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #1135
This creates a definition for Response Map, defined as the map normally returned by GraphQL queries and mutations containing data and/or errors.
The definition of Response is updated to include both Response Map, and Response Stream (for subscriptions).
For Incremental Delivery I plan on updating Response to also include Incremental Stream.
I went through every mention of
responseand most of the remaining usages are aroundresponse keyorresponse field, referring to the object property name (ie for aliases and error paths). This could also likely be standardized in a follow up.