Introduce @disableErrorPropagation #1145
Draft
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
martinbonnin
reviewed
Mar 9, 2025
| @@ -386,6 +386,8 @@ either resolving to {null} if allowed or further propagated to a parent field. | |||
| If this occurs, any sibling fields which have not yet executed or have not yet | |||
| yielded a value may be cancelled to avoid unnecessary work. | |||
|
|
|||
| This default error propagation behavior can be modified by using the `@disableErrorPropagation` directive on an operation. If this directive is present, field errors in non-null fields will not propagate to their parent fields. Instead, the field that experienced the error will return `null` (even if it's a non-null field) and the error will be added to the response's `errors` list, but parent fields will continue to be resolved normally. This allows clients to receive partial data with localized errors rather than having errors propagate and potentially nullify large portions of the response. | |||
There was a problem hiding this comment.
We might want to modify the existing text instead of adding a new paragraph. Read in isolation, the paragraph above become misleading.
Maybe just:
If during {ExecuteSelectionSet()} a field with a non-null {fieldType} raises a
_field error_ **and the operation does not define `@disableErrorPropagation`**
then that error must propagate to this entire selection set, ...
|
See also discussion in #1050 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.