Editorial: consistent field ordering in Circular References examples#1214
Merged
benjie merged 1 commit intographql:mainfrom Mar 9, 2026
Merged
Conversation
Reorder fields in the counter-example for self-referencing input types so that `self` appears before `value`, matching the field order used in all other examples in the Circular References section.
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
martinbonnin
approved these changes
Mar 9, 2026
Contributor
martinbonnin
left a comment
martinbonnin
left a comment
There was a problem hiding this comment.
Yay for consistency 👍
benjie
added
the
✏️ Editorial
benjie
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the section on Input Object Circular References, there are a number of examples that use the format
Specifically, the input objects define a
value: Stringfield that is the second field in the type definition.One of the definitions reverses the order of the fields, putting the
value: Stringdefinition first.This is a pedantic edit to change the ordering so that it has the same field ordering as the other examples in this section.
Suggested by @benjie in #1211 (comment).