-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add validation rule that operation types exist #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benjaminjkraft
wants to merge
20
commits into
graphql:main
Choose a base branch
from
benjaminjkraft:operation-type-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
be984cb
Add validation rule that operation types exist
benjaminjkraft 6b668ce
prettier
benjaminjkraft 011a9a5
typofix
benjaminjkraft 04197ab
indentation
benjaminjkraft b7bf107
Add 5.2.4 Operation Type Configuration
Shane32 94e2bda
Update spec/Section 5 -- Validation.md
Shane32 ef77474
Update spec/Section 5 -- Validation.md
Shane32 0f283f9
Update spec/Section 5 -- Validation.md
Shane32 6f187fa
Apply suggestions from code review
Shane32 f8fd141
Merge branch 'main' into Shane32-patch-1
Shane32 b9f1f33
Reformat
Shane32 d567789
Undo changes to Section 3
benjie 1482766
Merge branch 'main' into operation-type-validation
benjie 55d4fd4
Editorial
benjie 3d67537
Merge remote-tracking branch 'Shane32/Shane32-patch-1' into operation…
benjie eab709f
Move Shane's content
benjie 8c6f5df
More editorial
benjie 7a8975a
More editorial
benjie 06f237f
Update spec/Section 5 -- Validation.md
benjie b209bd8
Update spec/Section 5 -- Validation.md
benjie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or schema without curlies, I see both in the other algorithms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have existing algorithms that follow this pattern, e.g.
graphql-spec/spec/Section 5 -- Validation.md
Lines 664 to 666 in b41339a