-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone TLS configuration for WebSocket dialer #19396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Dec 15, 2022
smallinsky
approved these changes
Dec 15, 2022
@gabrielcorado See the table below for backport results.
|
gabrielcorado
added a commit
that referenced
this pull request
Dec 16, 2022
gabrielcorado
added a commit
that referenced
this pull request
Dec 16, 2022
This was referenced Dec 16, 2022
gabrielcorado
added a commit
that referenced
this pull request
Dec 19, 2022
gabrielcorado
added a commit
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19022 and added a test to cover the scenario described (
TestHandleConnectionHTTP2WS
).Problem
Teleport couldn't connect to WebSockets after issuing an HTTP2 request to the same server. This was caused because both dialers (for requests and WebSockets) were using the same TLS Configuration. When the user issued a request, and the server handled it as HTTP2, the configuration would be changed, and the following connections using the configuration would resolve to the same protocol. When a WebSocket request arrived, it would use HTTP2, which is not supported, causing the server to fail to upgrade the connection.
Logs from the server
Error from `TestHandleConnectionHTTP2WS` test before the fix
Solution
Clone the TLS configuration instead of using the same for both dialers. This enables requests and WebSockets from the same
sessionChunk
to use different protocols.